I'm trying to give certain users the rights to modify products and price books but they end up having access to price books and products that they should not.
3 answers
Record Types won't actually hide data from users completely. Products are a tricky one to magae since there is not an OWD sharing setting for them at the object level. You can set pricebooks globally to View Only and then use manual sharing to extend access but it's not a perfect fit. You can also leverage validation rules here. I have seen this implementd by creating a custom field on the user record, checl box for example that denotes if the user is allowed to modify products. Then in your validation rule you have the system check to see if the user has that field checked on their record. If not, they can't update the data. That helps keep the data clean but won't hide data from users should they go into reports for example. You can always hide the tab at the profile level as well but that again only addressess a part of the issue.
