Skip to main content
Shaun Bailey (defi SOLUTIONS) a posé une question dans #Apex
I'm a newbie for APEX and I'm trying to redeploy a fix for a former APEX trigger we had already deployed to production.  When I try to deploy it, I get it shows Code Coverage as 64% (9/14) and won't let me deploy.  Can someone please let me know what I'm doing wrong?

Apex Trigger:

trigger UpdatePricing on OpportunityLineItem (before insert, before update) {

Map<String, List<Volume_Discount__c>> PricingMap = new Map<String, List<Volume_Discount__c>>();

for(Volume_Discount__c P : [SELECT ID,Minimum_Quantity__c,Product__c,Price_Book__c FROM Volume_Discount__c ORDER BY Minimum_Quantity__c])

{

if(PricingMap.KeySet().contains(P.Product__c+'|'+P.Price_Book__c))

{

PricingMap.get(P.Product__c+'|'+P.Price_Book__c).add(P);

}

else

{

PricingMap.put(P.Product__c+'|'+P.Price_Book__c,new List<Volume_Discount__c> {P});

}

}

for(OpportunityLineItem oli : Trigger.new)

{

oli.Volume_Discount__c = null;

if(PricingMap.KeySet().contains(oli.Product2Id+'|'+oli.Opportuity_PriceBook2__c) && oli.ProductAndPriceBookActive__c)

{

for(Volume_Discount__c P : PricingMap.get(oli.Product2Id+'|'+oli.Opportuity_PriceBook2__c))

{

if(oli.quantity >= P.Minimum_Quantity__c)

{

oli.Volume_Discount__c = P.ID;

}

}

}

}

}

Apex Class:

@isTest

Public class UpdatePricingTest{

Public static testmethod void testing(){

integer def = 0;

list<OpportunityLineitem > olitoupdate = new list<OpportunityLineitem >();

for(OpportunityLineitem oli : [SELECT ID,Quantity from OpportunityLineItem order by createddate desc LIMIT 5]){

OLI.Quantity = def +200;

olitoupdate.add(OLI);

}

if(olitoupdate.size()>0){

update olitoupdate;

}

PriceBook2 PB = new PriceBook2();

PB.Name = 'New Pricebook';

PB.isactive = true;

insert PB;

Product2 pro = new Product2();

pro.Name = 'Prod';

pro.Billing_Type__c = 'Financed';

insert pro;

insert new PriceBookEntry(Product2Id=pro.Id, Pricebook2Id=Test.getStandardPricebookId(), UnitPrice=0);

PricebookEntry PBE = new PricebookEntry();

PBE.Product2ID = Pro.ID;

PBE.PriceBook2ID = PB.ID;

PBE.UnitPrice = 120;

PBE.Isactive = true;

insert PBE;

Volume_Discount__c Pricing = new Volume_Discount__c();

Pricing.Minimum_Quantity__c = 100;

Pricing.Product__c = Pro.ID;

Pricing.Price_Book__c = PB.ID;

Pricing.Annual_Overage__c = 2.5;

Pricing.Annual_Price__c = 2.5;

Pricing.Quarterly_Overage__c = 2.5;

Pricing.Quarterly_Price__c = 2.5;

Pricing.Monthly_Overage__c = 2.5;

Pricing.Monthly_Price__c = 2.5;

insert Pricing;

Account acc = new Account(Name = 'Test Account1');

acc.BillingState = 'TX';

acc.AccountSource = 'Inbound Call';

acc.Industry = 'Bank';

insert acc;

Opportunity Opp = new Opportunity();

Opp.Name = 'Test Opp';

Opp.StageName = 'Interview';

Opp.PriceBook2ID = PB.ID;

Opp.CloseDate = Date.TODAY()-10;

Opp.AccountID = acc.ID;

Opp.Testing__c = true;

insert Opp;

OpportunityLineItem OLI = new OpportunityLineItem();

OLI.OpportunityID = Opp.ID;

OLI.PriceBookEntryID = PBE.ID;

OLI.Quantity = 100;

OLI.Volume_Discount__c = Pricing.ID;

insert OLI;

OLI.Quantity = 99;

update OLI;

}

}

 
9 réponses
  1. 8 janv. 2020, 06:54
    Hi Bailey,

    Not sure about the business scenario you are trying to achieve in this trigger but if you are looking to get the coverage then you have to set ProductAndPriceBookActive__c  as true and assign Product2Id,Opportuity_PriceBook2__c for OpportunityLineItem.

     

    @isTest

    Public class UpdatePricingTest{

    Public static testmethod void testing(){

    integer def = 0;

    list<OpportunityLineitem > olitoupdate = new list<OpportunityLineitem >();

    for(OpportunityLineitem oli : [SELECT ID,Quantity from OpportunityLineItem order by createddate desc LIMIT 5]){

    OLI.Quantity = def +200;

    olitoupdate.add(OLI);

    }

    if(olitoupdate.size()>0){

    update olitoupdate;

    }

    PriceBook2 PB = new PriceBook2();

    PB.Name = 'New Pricebook';

    PB.isactive = true;

    insert PB;

    Product2 pro = new Product2();

    pro.Name = 'Prod';

    pro.Billing_Type__c = 'Financed';

    insert pro;

    insert new PriceBookEntry(Product2Id=pro.Id, Pricebook2Id=Test.getStandardPricebookId(), UnitPrice=0);

    PricebookEntry PBE = new PricebookEntry();

    PBE.Product2ID = Pro.ID;

    PBE.PriceBook2ID = PB.ID;

    PBE.UnitPrice = 120;

    PBE.Isactive = true;

    insert PBE;

    Volume_Discount__c Pricing = new Volume_Discount__c();

    Pricing.Minimum_Quantity__c = 100;

    Pricing.Product__c = Pro.ID;

    Pricing.Price_Book__c = PB.ID;

    Pricing.Annual_Overage__c = 2.5;

    Pricing.Annual_Price__c = 2.5;

    Pricing.Quarterly_Overage__c = 2.5;

    Pricing.Quarterly_Price__c = 2.5;

    Pricing.Monthly_Overage__c = 2.5;

    Pricing.Monthly_Price__c = 2.5;

    insert Pricing;

    Account acc = new Account(Name = 'Test Account1');

    acc.BillingState = 'TX';

    acc.AccountSource = 'Inbound Call';

    acc.Industry = 'Bank';

    insert acc;

    Opportunity Opp = new Opportunity();

    Opp.Name = 'Test Opp';

    Opp.StageName = 'Interview';

    Opp.PriceBook2ID = PB.ID;

    Opp.CloseDate = Date.TODAY()-10;

    Opp.AccountID = acc.ID;

    Opp.Testing__c = true;

    insert Opp;

    OpportunityLineItem OLI = new OpportunityLineItem();

    OLI.OpportunityID = Opp.ID;

    OLI.PriceBookEntryID = PBE.ID;

    OLI.Quantity = 100;

    OLI.TotalPrice=10;

    OLI.Volume_Discount__c = Pricing.ID;

    insert OLI;

    OLI.Quantity = 99;

    update OLI;

    OpportunityLineItem OLI2 = new OpportunityLineItem();

    OLI2.OpportunityID = Opp.ID;

    OLI2.PriceBookEntryID = PBE.ID;

    OLI2.Opportuity_PriceBook2__c=PB.ID;

    OLI2.Quantity = 100;

    OLI2.TotalPrice=10;

    OLI2.Volume_Discount__c = Pricing.ID;

    OLI2.ProductAndPriceBookActive__c =true;

    OLI2.Product2Id=Pro.ID;

    insert OLI2;

    OLI2.Quantity = 99;

    update OLI2;

    }

    }