Anyone Can Help Me

Question

i am getting this error for this trigger

trigger PriceUpdate on MyObject__c (before insert) {

list<MyObject__c> ilist = new list<MyObject__c>();

for(MyObject__c a:trigger.new){

If(a.Use_Standard_Price__c == true){

a.Standard_Price__c = a.Price__c;

ilist.add(a);

}

insert ilist;

}

Error: Invalid Data.

Review all error messages below to correct your data.

Apex trigger PriceUpdate caused an unexpected exception, contact your administrator: PriceUpdate: execution of BeforeInsert caused by: System.SObjectException: DML statement cannot operate on trigger.new or trigger.old: Trigger.PriceUpdate: line 13, column 1

Maharajan Chinnadurai · Accepted Answer

Hi Gouse,

Try the below Trigger:

trigger PriceUpdate on MyObject__c (before insert) {

for(MyObject__c a:trigger.new){

If(a.Use_Standard_Price__c == true){

a.Standard_Price__c = a.Price__c;

}

In before insert you don't have to use the DML Statement to overide the new records just the assign the values like above will make the respected changes.

Thanks,

Maharajan.C

Ajay Dubedi · Answer

Hi Gouse, You need to follow best practice which is used helper class for trigger. You should try below code: //Trigger trigger PriceUpdate on MyObject__c (before insert) {    if(Trigger.isBefore && Trigger.isInsert{         PriceUpdateClass.priceUpdateMethod(trigger.new);    } } // Trigger helper class public class PriceUpdateClass{     public static void priceUpdateMethod(List<MyObject__c> myobjectList){         for(MyObject__c myobj : myobjectList){             If(myobj.Use_Standard_Price__c == true){                            myobj.Standard_Price__c = myobj.Price__c;             }            }     } } I hope you find the above solution helpful. If it does, please mark as Best Answer to help others too. Thanks, Ajay Dubedi

Anyone Can Help Me

Salesforce Developer

Formation associée

Aide supplémentaire