SOQL in my trigger

Question

When an opportunity is updated, I have a trigger that checks the account and contact associated with that opportunity, and updates fields on the account and contact. To get that data, I'm using SOQL, but this causes errors when someone tries to bulk-update records.

How can I check the data from the related objects without using SOQL inside my trigger?

Here is the code I'm currently using (not the full trigger, just the beginning to show the problem area:

Thanks!

trigger SetCustomerStatusAfterOpWin on Opportunity (after insert, after update) {
    List<Contact> ContactsToUpdateListOriginal = new List<Contact>();
    List<Account> AccountsToUpdateListOriginal = new List<Account>();        
    for( Opportunity o : Trigger.new)
    {
        //Get contact from Opportunity
        string contactId = o.Primary_Contact__c;
        //Contact contactToUpdate = new Contact(Id = contactId);
        Contact contactToUpdate = [SELECT Id, RM_ID_Status__c, RSM_ID_Status__c, RWC_ID_Status__c
                                   FROM Contact
                                   WHERE Id = :contactId limit 1];
        //Get contacts account id
        string accountId = o.AccountId;
        //Account accountToUpdate = new Account(Id = accountId);      
        Account accountToUpdate = [SELECT Id, RM_ID_Status__c, RSM_ID_Status__c, RWC_ID_Status__c
                                   FROM Account
                                   WHERE Id = :accountId limit 1];
        //Get Opportunity's Name eg. RM-60013
        string opName = o.Name;
        //Update contact based on company and op status.
        if((opName.contains('RM') || opName.contains('RAMP')))
        {
           if( o.StageName == 'Closed Won')
           {
               //update contact by id
                if(contactToUpdate.Id != null)
                {
                    contactToUpdate.RM_ID_Status__c = 'Customer';
                    ContactsToUpdateListOriginal.add(contactToUpdate);
                    //update contactToUpdate;
                }
                //Update Contact's account status
                if(accountToUpdate.Id != null)
                {
                    accountToUpdate.RM_ID_Status__c = 'Customer';
                    AccountsToUpdateListOriginal.add(accountToUpdate);
                    //update accountToUpdate;         
                }
           }
           else if( o.StageName == 'Quote Sent' || o.StageName == 'Closed Lost' || o.StageName == 'Sale Pending' || o.StageName == 'Updated Quote')
           {
               //update contact by id
                if(contactToUpdate.Id != null && contactToUpdate.RM_ID_Status__c != 'Customer')
                {
                    contactToUpdate.RM_ID_Status__c = 'Quoted';
                    ContactsToUpdateListOriginal.add(contactToUpdate);
                    //update contactToUpdate;
                }
                //Update Contact's account status
                if(accountToUpdate.Id != null && accountToUpdate.RM_ID_Status__c != 'Customer')
                {
                    accountToUpdate.RM_ID_Status__c = 'Quoted';
                    AccountsToUpdateListOriginal.add(accountToUpdate);
                    //update accountToUpdate;         
                }
           }
        }// end if

Mathew Andresen · Accepted Answer

It looks to me like you are iterating the query over in the for loop. This will make you run into query limits. Instead you should do the query for the whole trigger set.

FROM Contact WHERE Id IN :Trigger.new

See the trailhead example here

https://developer.salesforce.com/trailhead/force_com_programmatic_beginner/apex_triggers/apex_triggers_bulk

Thanks,

Rapid Development · Answer

Thanks Mathew, I'm new to the world of triggers, you're link was exactly what I needed.

SOQL in my trigger

Apex

Aprendizagem relacionada

Mais ajuda