prevent email change on contact

Question

Hi

I have a requirement where once a contact record is saved with email, then on update the existing email cannot be changed.

I have the code working but what I wud like to know if I can use Map to further optimize my code.

public class NoEmail_Change
{
   public void Display(list<Contact> con,Map<Id,Contact> mymap)
   {
         for(contact n:con)
         {
             Contact old = new Contact();
             old = mymap.get(n.Id);  //get the Old Id of contacts
              if (n.Email != old.Email)
                             n.Email.addError('Email cannot be changed');
         }
}}   
 trigger trg_Email_Change on Contact (before Update)
{
            if (trigger.isBefore)
            {
                     if (trigger.isUpdate)
                     {
                           NoEmail_Change obj=new NoEmail_Change();
                           obj.Display(trigger.New,trigger.OldMap);
                     }      
            } 
}

I am quite sure my code will not hit governor ,imits but pls correct me if I am wrong.

Thanks

pooja Biswas

Amit Chaudhary · Accepted Answer

Your good is perfect. I did minor change with naming

public class NoEmail_Change
{
   public void Display(list<Contact> listNewCont, Map<Id,Contact> oldContactMap )
   {
		for(contact cont: listNewCont )
        {
			Contact old = oldContactMap.get(cont.Id);
			if (cont.Email != old.Email)
			{
				cont.Email.addError('Email cannot be changed');
			}				
        }
	}
}   
trigger trg_Email_Change on Contact (before Update)
{
            if (trigger.isBefore)
            {
                     if (trigger.isUpdate)
                     {
                           NoEmail_Change obj=new NoEmail_Change();
                           obj.Display(trigger.New,trigger.OldMap);
                     }      
            } 
}

http://amitsalesforce.blogspot.in/2015/06/trigger-best-practices-sample-trigger.html

1) One Trigger Per Object

A single Apex Trigger is all you need for one particular object. If you develop multiple Triggers for a single object, you have no way of controlling the order of execution if those Triggers can run in the same contexts

2) Logic-less Triggers

If you write methods in your Triggers, those can’t be exposed for test purposes. You also can’t expose logic to be re-used anywhere else in your org.

3) Context-Specific Handler Methods

Create context-specific handler methods in Trigger handlers

4) Bulkify your Code

Bulkifying Apex code refers to the concept of making sure the code properly handles more than one record at a time.

5) Avoid SOQL Queries or DML statements inside FOR Loops

An individual Apex request gets a maximum of 100 SOQL queries before exceeding that governor limit. So if this trigger is invoked by a batch of more than 100 Account records, the governor limit will throw a runtime exception

6) Using Collections, Streamlining Queries, and Efficient For Loops

It is important to use Apex Collections to efficiently query data and store the data in memory. A combination of using collections and streamlining SOQL queries can substantially help writing efficient Apex code and avoid governor limits

7) Querying Large Data Sets

The total number of records that can be returned by SOQL queries in a request is 50,000. If returning a large set of queries causes you to exceed your heap limit, then a SOQL query for loop must be used instead. It can process multiple batches of records through the use of internal calls to query and queryMore

8) Use @future Appropriately

It is critical to write your Apex code to efficiently handle bulk or many records at a time. This is also true for asynchronous Apex methods (those annotated with the @future keyword). The differences between synchronous and asynchronous Apex can be found

9) Avoid Hardcoding IDs

When deploying Apex code between sandbox and production environments, or installing Force.com AppExchange packages, it is essential to avoid hardcoding IDs in the Apex code. By doing so, if the record IDs change between environments, the logic can dynamically identify the proper data to operate against and not fail

Let us know if this will help you

prevent email change on contact

Apex

Risorse di formazione correlate

Ulteriore assistenza